Use Dynatrace v2 export as default unless deviceId is set #2727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
enhancement
shakuzen
reviewed
Aug 10, 2021
...ons/micrometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/DynatraceConfig.java
Show resolved
Hide resolved
jonatan-ivanov
approved these changes
Aug 11, 2021
...ons/micrometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/DynatraceConfig.java
Show resolved
Hide resolved
...ons/micrometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/DynatraceConfig.java
Outdated
Show resolved
Hide resolved
jonatan-ivanov
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces minor code changes to mimic the behavior of the Spring Boot integration for Dynatrace Micrometer Metrics. There, we changed the logic to fall back to the v2 exporter as a default, unless the
deviceIdproperty is set (spring-projects/spring-boot#26258 (comment)). This property is required for the v1 export, therefore all integrations currently using v1 will continue to work (since they specify thedeviceIdexplicitly).