Skip to content

Add an exporter for the Dynatace metrics API v2 #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
May 25, 2021
Merged

Add an exporter for the Dynatace metrics API v2 #2581

merged 0 commits into from
May 25, 2021

Conversation

@pirgeo
Copy link
Contributor

@pirgeo pirgeo commented Apr 27, 2021

This is the implementation for the Dynatrace metrics API v2.

Resolves #2295
Closes #2406

@pirgeo
Copy link
Contributor Author

pirgeo commented Apr 27, 2021

Would it be possible to rename the target branch from move-dynatrace-registry-v1 to something like update-dynatrace-registries? This might become quite confusing otherwise.

This was referenced Apr 27, 2021
Merged
Closed
@pirgeo
Copy link
Contributor Author

pirgeo commented Apr 27, 2021

We also opened PRs for the updated properties in Spring Boot and for the Micrometer documentation:

jonatan-ivanov
jonatan-ivanov requested changes May 7, 2021
View reviewed changes
@pirgeo
Copy link
Contributor Author

pirgeo commented May 18, 2021

Hi @jonatan-ivanov, I think I have addressed all of the comments, please take another look :)

@jonatan-ivanov jonatan-ivanov mentioned this pull request May 19, 2021
Closed
@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented May 20, 2021

@pirgeo Thank you very much. I back-merged master to the v1 refactor commit, I'm going to do some testing then merge it to master tomorrow. After that, I'm going to modify this PR and point to master and review your changes.

@pirgeo
Copy link
Contributor Author

pirgeo commented May 20, 2021

@jonatan-ivanov We have released a new version of the Dynatrace exporter library which enforces some of the restrictions that we checked in this code before. We included the updated version in the latest commit (bcd543d). The checks that were removed in this code are now handled in the library.

pirgeo
pirgeo commented May 20, 2021
View reviewed changes
...ter-registry-dynatrace/src/test/java/io/micrometer/dynatrace/v2/DynatraceExporterV2Test.java
Counter counter = meterRegistry.find("my.counter1").counter();
assertNotNull(counter);

// NaN and infinity are ignored. The counter value stays at 0.0 when adding one of NaN,
Copy link
Contributor Author

@pirgeo pirgeo May 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonatan-ivanov Please verify that the behavior we are experiencing here is expected.

@jonatan-ivanov jonatan-ivanov changed the base branch from dynatrace-v1-refactor to add-dynatrace-registry-v2 May 25, 2021 21:34
@jonatan-ivanov jonatan-ivanov merged commit bcd543d into micrometer-metrics:add-dynatrace-registry-v2 May 25, 2021
@jonatan-ivanov jonatan-ivanov force-pushed the add-dynatrace-registry-v2 branch from 5bc68e1 to bcd543d Compare May 25, 2021 22:08
@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented May 25, 2021 •
edited
Loading

I merged the v1 refactor branch to main and deleted it. Since this was pointing to the v1 refactor, I pushed this to add-dynatrace-registry-v2 so that I can work on it too (which marked this PR as merged). I also back-merged main to it so that it is up-to-date. I'm going to clean-up a few things and take a look at your validation changes: #2619

@pirgeo pirgeo deleted the add-dynatrace-registry-v2 branch March 10, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonatan-ivanov jonatan-ivanov jonatan-ivanov requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pirgeo @jonatan-ivanov