URI tag of http.server.requests meter does NOT contain templated URI for jersey

[mikksoone]

Created minimal working example by:

1. start.spring.io with jersey, actuator, hateoas
2. Created jersey endpoint:

@Path("ping")
@Component
public class PingResource {

	@GET
	@Path("/{id}")
	public String ping(@PathParam("id") String id) {
		return id;
	}
}

3. Registered jersey endpoint

@Component
public class JerseyConfig extends ResourceConfig {

	public JerseyConfig() {
		this.register(PingResource.class);
	}

}

4. Main method just in case:

@SpringBootApplication
@EnableAutoConfiguration
public class JerseymetricsApplication {

	public static void main(String[] args) {
		SpringApplication.run(JerseymetricsApplication.class, args);
	}
}

5. Genereted metrics: curl http://localhost:8080/ping/3
6. Output from metrics: curl http://localhost:15556/actuator/metrics/http.server.requests

{"name":"http.server.requests","measurements":[{"statistic":"COUNT","value":4.0},{"statistic":"TOTAL_TIME","value":0.142668096},{"statistic":"MAX","value":0.069735286}],"availableTags":[{"tag":"exception","values":["None"]},{"tag":"method","values":["GET"]},{"tag":"uri","values":["/ping/4","/ping/3"]},{"tag":"status","values":["200"]}]}%

The bug?: Notice how /ping/4 and /ping/3 are both uris, and its not templated to /ping/{id}

[mweirauch]

Just some things to check here:

• You are running Spring-Boot 1.5?
• You included the micrometer-jersey2 dep?

What I am doing to remedy this situation in Spring-Boot 1.5 where you can't get rid of spring-web when using actuator:

• operate Jersey in servlet filter mode: spring.jersey.type=filter
• register the Jersey filter before the Spring MVC (or rather Micrometer) MetricsFilter spring.jersey.filter.order=-2147483648

This way Jersey knows the URL and handles it before the MetricsFilter does kick in. With Spring-Boot 2.0 this pain is gone as Jersey has become a first class citizen and one isn't forced to host two "web technologies". Does this help?

[jkschneider]

Refer to initial comments on #228

[mweirauch]

From the referenced spring-boot issue we know that we are talking spring-boot 2 here. The missing auto-configuration for Jersey-Micrometer instrumentation is missing.
Also, the fact that spring-hateoas pulls in spring-webmvc which makes the WebMVC MetricsFilter kick in and produce http.server.requests but of course with untemplated URIs.

So the solution is to provide the same Jersey-Micrometer configuration for spring-boot 2 as we do with micromter-spring-legacy.

A follow-up topic would be to identify if it is possible to get spring-hateoas not depend on spring-webmvc. if you really wan't Jersey. I just learned yesterday that it also has Jersey support. But I have no further experience with spring-hateoas at all.

[shakuzen]

With spring-projects/spring-boot#12482, this works as long as you you add the micrometer-jersey2 dependency and exclude org.springframework:spring-webmvc from the spring-boot-starter-hateoas dependency. Having both WebMVC and Jersey on the classpath will result in double instrumentation of Jersey endpoints. I'm imagining the original intention was not to use both anyways.