rename unadorned bucket to crudbucket

storage/kv/bucket.go

@@ -28,8 +28,11 @@ type RWBucket interface {
 	Delete(ctx context.Context, key string) error
 }
 
-// Bucket defines simple read-write operations for key-value stores.
-type Bucket interface {
+// CRUDBucket defines simple read-write operations for key-value stores.
+type CRUDBucket interface {
 	ROBucket
 	RWBucket
 }
+
+// Bucket is an alias for any commonly used key-value store.
+type Bucket = CRUDBucket

storage/kv/keys.go

@@ -22,14 +22,14 @@ type KeysPrefixTraverser interface {
 
 // KeysTraversingBucket is a key-value store that can traverse keys.
 type KeysTraversingBucket interface {
-	Bucket
+	CRUDBucket
 	KeysTraverser
 }
 
 // KeysPrefixTraversingBucket is a key-value store that can traverse keys.
 // Inlcuding using a prefix.
 type KeysPrefixTraversingBucket interface {
-	Bucket
+	CRUDBucket
 	KeysTraverser
 	KeysPrefixTraverser
 }

storage/kv/test/bucket.go

@@ -9,7 +9,7 @@ import (
 	"github.com/micromdm/nanolib/storage/kv"
 )
 
-func TestBucketSimple(t *testing.T, ctx context.Context, b kv.Bucket) {
+func TestBucketSimple(t *testing.T, ctx context.Context, b kv.CRUDBucket) {
 	const testKey1 = "test_key_1"
 	const testKey2 = "test_key_2"
 	const testValue1 = "test_value_1"