Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➖ Removing "react-hot-loader" package #34

Merged

Conversation

VadimZvf
Copy link
Contributor

This package is deprecated and there's no plans to support it for React 18.
gaearon/react-hot-loader#1808 (comment)

What do you think if we remove it?
The webpack hot module replacement works well even without "react-hot-loader".

The problem I'm trying to solve is this error:
Screenshot 2024-08-16 at 15 58 45

Also I wanna update some dependencies to resolve all similar dependency errors.

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-json-view ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 8:09pm

@VadimZvf
Copy link
Contributor Author

Also, this package wasn't used 😀
We don't use it in the webpack config
https://github.com/microlinkhq/react-json-view/blob/master/webpack/webpack.config.js#L37

@Kikobeats
Copy link
Member

This is a good catch, thanks for it 🙂

This package is depricated, there's no plans to support it for React 18
@Kikobeats Kikobeats force-pushed the VadimZvf/removing-react-hot-loader branch from 7eebe0f to 05bcc19 Compare September 22, 2024 20:09
@Kikobeats Kikobeats merged commit be65f2f into microlinkhq:master Sep 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants