Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date): add datePublished and datemodified support #374

Merged
merged 16 commits into from
Mar 11, 2023
Merged

feat(date): add datePublished and datemodified support #374

merged 16 commits into from
Mar 11, 2023

Commits on Feb 25, 2021

  1. Add published and modified dates 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    90ad860 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Fix tests 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    5980e59 View commit details
    Browse the repository at this point in the history

  2. Fix more tests 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ea2e100 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Merge code 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    03ed720 View commit details
    Browse the repository at this point in the history

  2. Merge master 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    78433d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Fxi modified date 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    88b1df3 View commit details
    Browse the repository at this point in the history

  2. New line 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9782eb8 View commit details
    Browse the repository at this point in the history

  3. Wee need concat rules 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    fddd2f2 View commit details
    Browse the repository at this point in the history

  4. Closer to old behaviour of date 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    426df15 View commit details
    Browse the repository at this point in the history

  5. YouTube does not seem to use <meta date> 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3a1d775 View commit details
    Browse the repository at this point in the history

  6. Add date docs 

    Signed-off-by: Stiliyan Ivanov <[email protected]>
    @madwings
    madwings committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5400040 View commit details
    Browse the repository at this point in the history

  7. Update README.md

    @Kikobeats
    Kikobeats authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    aa6af27 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. test: don't modify previous fixtures

    @Kikobeats
    Kikobeats committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    2222186 View commit details
    Browse the repository at this point in the history

  2. test: update snapshot 

    The rule:

```
toDate($ => $filter($, $('[class*="publish" i]')))
```

is taking more priority than:

```
toDate($ => $('[property*="dc:date" i]').attr('content'))
```

It's okay for this case since it's a fuzzy rule so isn't too deterministic
    @Kikobeats
    Kikobeats committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    b60e5ec View commit details
    Browse the repository at this point in the history

  3. test: update snapshot 

    The rule

```
toDate($ => $('[itemprop="datepublished" i]').attr('content'))
```

It's taking more priority than:

```
toDate($ => $('meta[name="date" i]').attr('content')
```

It's okay for this case since it's a fuzzy rule so isn't too deterministic
    @Kikobeats
    Kikobeats committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c4650ff View commit details
    Browse the repository at this point in the history

  4. test: update snapshot

    @Kikobeats
    Kikobeats committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    af1691e View commit details
    Browse the repository at this point in the history