strip script and style tags from parsed html #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the failing test in 5.4 by allowing that version in 5.4 and below
aaronpk
changed the title
aaronpk
added a commit
to aaronpk/XRay
that referenced
this pull request
Feb 29, 2016
use fork of php-mf2 until microformats/php-mf2#83 is merged
Member
Author
|
@barnabywalters Care to review this change? Between this PR and the last one (#82) I'd love to get a new release published. |
Collaborator
|
Thanks for the PR! I’m strongly in favour of removing these elements from plaintext properties, but strongly against removing them from raw html properties. I mentioned this objection in IRC and on http://microformats.org/wiki/microformats2-parsing-issues#exclude_style_elements_before_parsing, awaiting feedback from other implementors. |
Member
Author
|
@barnabywalters agreed! Feel free to revise this PR. |
Collaborator
|
Revised and merged! Thanks for you work on this issue @aaronpk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e-class. adds failing test to demonstrate that.