Implement HTML id parsing proposal #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zegnat
requested changes
Nov 19, 2018
Member
Zegnat
left a comment
Zegnat
left a comment
There was a problem hiding this comment.
This looks like a straight forward enough change! Just the one little nitpick.
Also wondering if we should some edge-case tests? The following come to mind:
id="0"– to make sure the falsy test is correct; andid=""– though we need to decide whether this gets added to the parsed object or not. I think not.
Co-Authored-By: sknebel <[email protected]>
Member
Author
|
Can add the test cases. Agreed |
Zegnat
approved these changes
Nov 19, 2018
Member
Zegnat
left a comment
Zegnat
left a comment
There was a problem hiding this comment.
LGTM! Just waiting for Travis to also turn up green on the tests.
Member
|
I'd suggest |
sknebel
force-pushed
the
implement-id-proposal
branch
from
e23f0a3 to
10ea6b6
Compare
Member
|
I went ahead and merged this. As I had already completely forgotten about it… Letting reviewed patches sit and get stale seems wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #206 / microformats/microformats2-parsing#44