fix blocking recv call on httpTransportClient

micro · Dec 29, 2024 · 9ee16e2 · 9ee16e2
1 parent 2529793
commit 9ee16e2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/transport/http_client.go b/transport/http_client.go
@@ -111,7 +111,15 @@ func (h *httpTransportClient) Recv(msg *Message) (err error) {
 	var req *http.Request
 
 	if !h.dialOpts.Stream {
-		rc, ok := <-h.req
+
+		var rc *http.Request
+		var ok bool
+
+		select {
+		case rc, ok = <-h.req:
+		default:
+		}
+
 		if !ok {
 			h.Lock()
 			if len(h.reqList) == 0 {

diff --git a/transport/http_client_test.go b/transport/http_client_test.go
@@ -7,7 +7,7 @@ import (
 	"github.com/pkg/errors"
 )
 
-func TestHttpClientTransport(t *testing.T) {
+func TestDefaultHttpClientTransport(t *testing.T) {
 	// arrange
 	l, c, err := echoHttpClient("127.0.0.1:")
 	if err != nil {