Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/windows build #82

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Feature/windows build #82

wants to merge 14 commits into from

Conversation

norro
Copy link
Collaborator

@norro norro commented Jun 1, 2021

This PR introduces the necessary changes to build the system modes packages on Windows, e.g., visibility control.
Part of #35 and the quality level

norro added 13 commits April 12, 2021 14:31
Separated msg and srv types into seperate package . This seems to be the
ROS 2 way anyway, was requiring a hack beforehand, and seems necessary
to get windows build working.

Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Adapts system_modes and system_modes_example packages to separated system_modes_msgs interface package.

Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Arne Nordmann (CR/AEA2) <[email protected]>
Signed-off-by: Arne Nordmann (CR/AEA2) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
@norro norro self-assigned this Jun 1, 2021
@norro norro added the enhancement New feature or request label Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #82 (b63631e) into master (fdeb512) will increase coverage by 0.47%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   31.67%   32.15%   +0.47%     
==========================================
  Files          14       11       -3     
  Lines        1048     1048              
  Branches      754      754              
==========================================
+ Hits          332      337       +5     
+ Misses        157      142      -15     
- Partials      559      569      +10     
Impacted Files Coverage Δ
...ystem_modes/include/system_modes/mode_handling.hpp 100.00% <ø> (ø)
system_modes/src/system_modes/mode_impl.cpp 38.37% <ø> (ø)
system_modes/src/system_modes/mode_manager.cpp 17.60% <50.00%> (+1.06%) ⬆️
system_modes/include/system_modes/mode.hpp 100.00% <100.00%> (ø)
system_modes/include/system_modes/mode_impl.hpp 81.48% <100.00%> (ø)
...stem_modes/include/system_modes/mode_inference.hpp 100.00% <100.00%> (ø)
system_modes/src/system_modes/mode_monitor.cpp 27.55% <100.00%> (+0.57%) ⬆️
system_modes/src/system_modes/mode_observer.cpp 21.56% <100.00%> (+1.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdeb512...b63631e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant