Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce macos build and windows build #57

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

norro
Copy link
Collaborator

@norro norro commented Feb 9, 2021

No description provided.

norro added 16 commits July 24, 2020 16:54
Signed-off-by: Arne Nordmann <[email protected]>
Signed-off-by: Arne Nordmann <[email protected]>
This is now closer to the according TransitionEvent of lifecycle_msgs,
which includes the start_state and goal_state of a transition.

Signed-off-by: Arne Nordmann <[email protected]>
* Adds caching of latest reported states/modes of all systems
* Adds infer_transitions method that compares currently inferred
states/modes to cached ones and returns transitions, if detected

#42

Signed-off-by: Arne Nordmann <[email protected]>
Signed-off-by: Arne Nordmann <[email protected]>
Mode manager is now publishing transitions that are inferred by the mode
inference, i.e. state and mode transitions of systems, mode transitions
of nodes.
State transitions of nodes don't have to be published as lifecycle nodes
do this on their own.

#42

Signed-off-by: Arne Nordmann <[email protected]>
Signed-off-by: Arne Nordmann <[email protected]>
* Adding exec_depend to launch_ros to system_modes package due to
included launch files
* Adding exec_depend to ros2launch to system_modes_examples package due
to step-by-step CLI example

Signed-off-by: Arne Nordmann <[email protected]>
Signed-off-by: Arne Nordmann <[email protected]>
@norro norro self-assigned this Feb 9, 2021
@norro norro marked this pull request as draft February 9, 2021 15:26
@norro norro force-pushed the feature/win-and-macos-build branch from 1d5c02d to 70c902d Compare February 10, 2021 07:25
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
@norro norro force-pushed the feature/win-and-macos-build branch from 70c902d to e013b03 Compare February 10, 2021 07:38
@codecov-io
Copy link

codecov-io commented Mar 3, 2021

Codecov Report

Merging #57 (4538772) into master (2eee57b) will increase coverage by 6.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   21.29%   27.54%   +6.25%     
==========================================
  Files          12       12              
  Lines         991      991              
  Branches      711      711              
==========================================
+ Hits          211      273      +62     
+ Misses        503      276     -227     
- Partials      277      442     +165     
Impacted Files Coverage Δ
system_modes/src/system_modes/mode_impl.cpp 38.37% <0.00%> (+2.32%) ⬆️
system_modes/src/system_modes/mode_inference.cpp 35.14% <0.00%> (+4.90%) ⬆️
system_modes/src/system_modes/mode_manager.cpp 15.64% <0.00%> (+15.26%) ⬆️
system_modes/include/system_modes/mode_manager.hpp 100.00% <0.00%> (+100.00%) ⬆️
...ystem_modes/include/system_modes/mode_handling.hpp 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eee57b...4538772. Read the comment docs.

@norro norro force-pushed the master branch 3 times, most recently from 66af650 to 3b797ca Compare May 5, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants