Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory release on entities creation (backport #280) #281

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 26, 2023

This is an automatic backport of pull request #280 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Update CI

* Fix memory release on entity creation

Signed-off-by: acuadros95 <[email protected]>

* Update node destroy on error

Signed-off-by: acuadros95 <[email protected]>

* Uncrustify

Signed-off-by: acuadros95 <[email protected]>

Signed-off-by: acuadros95 <[email protected]>
(cherry picked from commit 6df0003)
@github-actions
Copy link

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 280 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34500 B

@codecov-commenter
Copy link

Codecov Report

Base: 47.90% // Head: 47.82% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (1a87a98) compared to base (a08c301).
Patch coverage: 42.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   47.90%   47.82%   -0.09%     
==========================================
  Files          45       45              
  Lines        1745     1744       -1     
  Branches      501      508       +7     
==========================================
- Hits          836      834       -2     
- Misses        678      679       +1     
  Partials      231      231              
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_node.c 39.25% <0.00%> (-3.18%) ⬇️
rmw_microxrcedds_c/src/rmw_microxrcedds_topic.c 43.33% <25.00%> (-0.22%) ⬇️
rmw_microxrcedds_c/src/rmw_publisher.c 48.09% <60.00%> (ø)
rmw_microxrcedds_c/src/rmw_subscription.c 52.51% <60.00%> (ø)
rmw_microxrcedds_c/src/rmw_client.c 46.55% <100.00%> (+1.17%) ⬆️
rmw_microxrcedds_c/src/rmw_service.c 45.68% <100.00%> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Acuadros95 Acuadros95 merged commit 5a62cae into main Jan 26, 2023
@Acuadros95 Acuadros95 deleted the mergify/bp/main/pr-280 branch January 26, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants