Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameter server tutorial with rolling #366

Merged
merged 8 commits into from
Apr 19, 2022
Merged

Update parameter server tutorial with rolling #366

merged 8 commits into from
Apr 19, 2022

Conversation

Acuadros95
Copy link
Contributor

No description provided.

@Acuadros95 Acuadros95 requested a review from pablogs9 April 5, 2022 12:41
@Acuadros95 Acuadros95 mentioned this pull request Apr 5, 2022
Merged
@Acuadros95
Copy link
Contributor Author

Acuadros95 commented Apr 5, 2022 •
edited
Loading

Looks like Capra logo link is broken

Fixed on 20b408c

pablogs9
pablogs9 previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only minor comments

_docs/tutorials/programming_rcl_rclc/parameters/parameters.md Outdated Show resolved Hide resolved
_docs/tutorials/programming_rcl_rclc/parameters/parameters.md Outdated Show resolved Hide resolved
_docs/tutorials/programming_rcl_rclc/parameters/parameters.md Show resolved Hide resolved
@pablogs9 pablogs9 merged commit a01078f into master Apr 19, 2022
@pablogs9 pablogs9 deleted the feature/param_upgrade branch April 19, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acuadros95 @pablogs9