#261 Add copy to clipboard functionality to Raw Response #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
micmro
commented
Oct 7, 2019
micmro
commented
|
Looks great but what bout moving it to content folder: That way we copy/paset just the HTML/content and that makes it easier when comparing old data. |
|
Ah, ok that was the one you meant 😄. For some reason I though about the raw data. What do you think of showing it in both? Copying the raw data is quite a pain too. |
micmro
commented
Oct 7, 2019
| overlay.onClose(overlay.index); | ||
| body.removeEventListener("click", onTabDataCopyClick); | ||
| }); | ||
| body.addEventListener("click", onTabDataCopyClick); |
There was a problem hiding this comment.
use event delegation as we can't bind callbacks before the tab has been added to the DOM, this also allows us to clean up the event listeners when it gets removed.
|
Both sounds great :) |
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.