Set row max time from outside of PerfCascade #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use case for this is when you wanna put to waterfall charts on top on each other and you wanna make sure they have the same time line, so it is easier to compare them.
|
hmm Travis fails, it's a new updated tslint that gets installed. |
|
Hi Peter. Thanks for the PR. I'm just traveling Norther Irland and are on
the road a lot, will look at this when I head to Canada in a few days.
Best,
Michael
On 22 Aug 2017 7:05 a.m., "Peter Hedenskog" <[email protected]> wrote:
hmm Travis fails, it's a new updated tslint that gets installed.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#211 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABmkBlV1YeQhtkUjYp9sO4KA8KOGujPGks5sam-WgaJpZM4O-JdM>
.
|
|
No worries. I'll update the dependencies. Need your help then how you want the interface for options, I don't fully follow that :) |
|
Looks good, but should we perhaps call it |
micmro
approved these changes
Aug 24, 2017
|
Yes agree, changed the name! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case for this is when you wanna put to waterfall charts on top on each other and you wanna make sure they have the same time line, so it is easier to compare them.