Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-axis value disappearing in waterfall model representation of page load #288

Closed
manjunathpremkumar opened this issue Sep 20, 2022 · 5 comments · Fixed by #290
Closed

x-axis value disappearing in waterfall model representation of page load #288

manjunathpremkumar opened this issue Sep 20, 2022 · 5 comments · Fixed by #290
Assignees
Labels

Comments

@manjunathpremkumar
Copy link

Hi,

We noticed that in our one of scripted journey test, x-axis values (in seconds) are not appearing for waterfall model representation of page load. We are able to reproduce this issue multiple times. Attached the HAR file for the page loaded and screenshot of the issue.

IBE_Guest_PassengerDetails_Page_Load-chrome-2022-09-07183603.har.gz
X-axis
Note: This is happening for this particular user journey and not for other journeys.

@manjunathpremkumar
Copy link
Author

@soulgalore - by any chance you got time to see this issue, I know you will be super occupied :)

@micmro
Copy link
Owner

micmro commented Nov 12, 2022

Looks like this has to do with floating point precision in this function:
https://github.com/micmro/PerfCascade/blob/main/src/ts/waterfall/sub-components/svg-general-components.ts#L71-L85

Will dig into this more durning the weekend.

@micmro micmro self-assigned this Nov 12, 2022
@micmro micmro added the bug label Nov 12, 2022
micmro added a commit that referenced this issue Nov 12, 2022
micmro added a commit that referenced this issue Nov 12, 2022
Breaking Change: To support BigInt the compile target has changed to ES2020,
therefore Internet Explorer is no longer supported.
@micmro
Copy link
Owner

micmro commented Nov 13, 2022

Fixed with 3.0.3

@micmro
Copy link
Owner

micmro commented Nov 13, 2022

Screen Shot 2022-11-12 at 9 39 17 PM

@manjunathpremkumar
Copy link
Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants