Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome generates broken HAR #244

Closed
kabilan-ravi opened this issue Apr 4, 2019 · 6 comments
Closed

Chrome generates broken HAR #244

kabilan-ravi opened this issue Apr 4, 2019 · 6 comments

Comments

@kabilan-ravi
Copy link

Hi, I am using sitespeed to collect frontend performance. Recently i updated sitespeed to 8.9.0 docker image. After upgrade waterfall reports taken from har is not displaying properly. The timelines are missing.
Please find the har and console error that i got while viewing the har.

Screenshot 2019-04-04 at 12 25 06 PM

Screenshot 2019-04-04 at 11 26 50 AM

[AllTickets-chrome-2019-04-03075521.har.gz](https://github.com/micmro/PerfCascade/files/3042675/AllTickets-chrome-2019-04-03075521.har.gz)
@kabilan-ravi
Copy link
Author

I checked with sitespeed team, it seems to be the issue with broken har. So raising bug here

@micmro
Copy link
Owner

micmro commented Apr 4, 2019

Cool thanks @kabilan-ravi!

@micmro micmro closed this as completed Apr 4, 2019
@soulgalore soulgalore reopened this Apr 5, 2019
@soulgalore
Copy link
Collaborator

Let me re-open, I think we still could handle this better right? I can have a look on Sunday. There are some timings missing but we should catch that I think.

micmro added a commit that referenced this issue Apr 5, 2019
else skip and add warning in console
@micmro
Copy link
Owner

micmro commented Apr 5, 2019

I quickly looked at it and have a fix for it in #245, however the visualization misses the initial time and starts from the first valid time.
Screen Shot 2019-04-05 at 9 21 35 AM

@kabilan-ravi
Copy link
Author

@micmro and @soulgalore Thanks for the fix.

soulgalore pushed a commit that referenced this issue Apr 8, 2019
else skip and add warning in console
@micmro
Copy link
Owner

micmro commented Apr 8, 2019

released with v2.5.7

@micmro micmro closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants