Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose which HAR (page) to show in the API #168

Closed
soulgalore opened this issue Feb 28, 2017 · 2 comments
Closed

Choose which HAR (page) to show in the API #168

soulgalore opened this issue Feb 28, 2017 · 2 comments
Assignees
@micmro
Labels
enhancement

Comments

@soulgalore
Copy link
Collaborator

Today we have the options to choose what page to show with the pageSelector but we have a use case in sitespeed.io where we want to choose what page to start to show (default now is always the first one). We should add a extra option, to choose the exact page to show.
@micmro micmro self-assigned this Mar 1, 2017
micmro pushed a commit that referenced this issue Mar 1, 2017
#168 add option to choose first rendered page
8f89997
micmro added a commit that referenced this issue Mar 1, 2017
@micmro
Merge pull request #169 from micmro/168
bfecb1b 
#168 add option to choose first rendered page
@micmro micmro closed this as completed Mar 1, 2017
@micmro
Copy link
Owner

micmro commented Mar 1, 2017

released with v0.7.0

@soulgalore
Copy link
Collaborator Author

Thanks for fixing this so fast! Pushing it in the next sitespeed.io release, this helps us so we can get rid of inlining the HAR if the pages are served by a server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micmro micmro

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soulgalore @micmro