-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some style nits #142
Comments
@micmro adding another one here about the 'Raw Data' tab. It would look better with a |
- move `output` style out of mundle css - add explicit button pointer cursor (do not rely on outside styles)
Thanks for the feedback. Some really good ideas. Only 4. looks like an issue with your local CSS. It seems you give your |
Wow great changes! One thing about the raw tab: The HAR file can contain HTML in the text element (I can add a link to an example later today) and that HTML will run in the raw tab as it is now and if it is inline CSS, it can change the look and feel of the page. |
Let me create a separate issue for that :) |
@micmro Strange, my page only has a handful other style rules. Could it be that on the demo page there's a css reset that sets button color to |
Right, I use CSS normalizer in both the preview and the demo page - was not aware that buttons do not inherit the colour by default (learn something new every day :)). Should be fixed with this PR then. |
Not sure you want to go that route, but it should be possible with a preprocessor to scope normalize.css to |
I had thought about this in the beginning of the project, but decided that most project use some reset anyway - I also wanted to keep the styles as simple and easily over-writable as possible. |
👍 totally reasonable |
- make raw view fill the whole holder - move `output` style out of bundle css - add explicit button pointer cursor (do not rely on outside styles) - add header link and row pointer - added some more type comments - remove normalize from dev-bundle. - replace WaterfallEntry's name with url
released with |
Some suggestions I've been collecting over the few weeks I've been using this library (really loving it so far):
Use a nicer icon for close button like: ✕ (U+2715).
![screen shot 2017-02-07 at 17 17 28](https://cloud.githubusercontent.com/assets/2109932/22744404/92d379cc-ee1d-11e6-9830-51ca9ab6744d.png)
Use pointer cursor for the rows to indicate they're clickable
![cursor](https://cloud.githubusercontent.com/assets/2109932/22744592/129412a2-ee1e-11e6-8168-984350853870.png)
Also, the tabs "General", "Request",... don't have a pointer cursor.
make the
<h3>
in the details view an anchor tag, so it's easier to navigate to it directly and easier to copy with "Copy Link Address"Sometimes the contrast between text color and background color make tab titles hard to read
![screen shot 2017-02-08 at 16 39 27](https://cloud.githubusercontent.com/assets/2109932/22744745/96322bd0-ee1e-11e6-9e9e-49d211059d7b.png)
The text was updated successfully, but these errors were encountered: