Use asyncio.run instead of get_event_loop() #155

hrnciar · 2023-02-22T08:40:40Z

Fixes: #154

src/tests/test.py

barraponto · 2023-07-10T15:35:32Z

src/tests/test.py

+    try:
+        from asyncio import run
+        aio_run = run
+    except ImportError:
+        # Python 3.5
+        from asyncio import get_event_loop
+        return get_event_loop().run_until_complete(awaitable)
+    else:
+        return aio_run(awaitable)


I guess the aio_run = run was meant to define the runner on both try / except branches, right?
If you're not going to do it anymore, there's no need for the aio_run alias, let's drop it.

micheles reviewed Feb 24, 2023

View reviewed changes

src/tests/test.py Show resolved Hide resolved

Use asyncio.run instead of get_event_loop()

8eb934f

Fixes: micheles#154

hrnciar force-pushed the python3.12-get_event_loop branch from da77a56 to 8eb934f Compare February 27, 2023 10:29

barraponto reviewed Jul 10, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use asyncio.run instead of get_event_loop() #155

Use asyncio.run instead of get_event_loop() #155

hrnciar commented Feb 22, 2023

barraponto Jul 10, 2023

Use asyncio.run instead of get_event_loop() #155

Are you sure you want to change the base?

Use asyncio.run instead of get_event_loop() #155

Conversation

hrnciar commented Feb 22, 2023

barraponto Jul 10, 2023

Choose a reason for hiding this comment