Right click menu #463
Right click menu #463
Conversation
dash.js
Outdated
| // Popup menu | ||
| this.menu = new PopupMenu.PopupMenu(this.actor, alignment, this._position); | ||
| this.menu.actor.hide(); | ||
| this.menu.actor.add_style_class_name('panel-menu'); |
There was a problem hiding this comment.
Skipping this css class seems to fix the issue with the additional spacing between the menu and the dock when on bottom. Why do we need this class?
There was a problem hiding this comment.
Ah, thanks for spotting it! I don't think it's strictly needed, I might have added when trying different styles. Let me remove that, check and resubmit.
|
An additional thing: if the popupmenu is open, one can open simultaneusly another popupmenu of the launchers. This is at odds with the behaviour of the others menus, which can only be open one at a time. |
|
As usual, your reviews are very thorough. Congrats! I pushed two new commits to fix both issues. Thanks. |
|
Thanks for the quick fixes! For the popupmenu, it's still not the same behaviour of the other launchers (which is fist click close the popupmenu, second click open a new one). I guess this is because the applications launchers are children of the actor to which this new popupmenu is attached, and therefore remain active? If so I would't know how to fix this. |
|
Yes, I'd need to wire children to parents... As usual with a lot of features I propose, I try to be minimal to help with maintainability. Let me give a try, if it gets too hard I'll leave it as it is. |
|
If it gets too messy, I can live with the current status. I'm mainly concern about it hidings additional weird behaviours. |
|
Ok, I'll leave as it is. We should then perhaps open an issue to keep this in mind. Is it ok? |
franglais125
force-pushed
the
right_click_menu_squashed
branch
from
aeba6f6 to
eda8607
Compare
|
I just rebased against current master, and added a commit simplyfying the logic in the _rightClickMenu function. |
franglais125
force-pushed
the
right_click_menu_squashed
branch
from
eda8607 to
115e5d3
Compare
|
I rebased this branch on master (after the multi-monitor merge), and added a commit to support multiple docks. |
franglais125
force-pushed
the
right_click_menu_squashed
branch
from
115e5d3 to
979daa6
Compare
I've tried a few times to fix this remaining issue. I wanted to know if you have perhaps an idea on how to go about this. When the popup menu is shown, all elements on the screen behave properly. It's only the appIcons that are still clickable. |
franglais125
force-pushed
the
right_click_menu_squashed
branch
2 times, most recently
from
f6fc688 to
59aac6e
Compare
franglais125
force-pushed
the
right_click_menu_squashed
branch
from
59aac6e to
1574446
Compare
franglais125
force-pushed
the
right_click_menu_squashed
branch
from
1574446 to
eeb066b
Compare
|
@micheleg I just had to perform a rebase due to the reworking of the |
franglais125
force-pushed
the
right_click_menu_squashed
branch
2 times, most recently
from
84a789b to
017da52
Compare
franglais125
force-pushed
the
right_click_menu_squashed
branch
from
017da52 to
1b7586e
Compare
|
Rebased following the code reorganization! |
I reworked the commits on a new branch to bring it down to two commits, so that we have an easier log history.
Do you think it's ready as it is?