vendor Jason to prevent conflicts #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents module conflicts with the user's version of Jason since both are loaded into the same beam instance (at least until #253) is addressed.
|
Sorry, didn't mean to submit this PR here! Was meant to be directly against https://github.com/elixir-lsp/jason |
|
I think long-term it should be possible to do a small script doing the re-writing. I don't think there's any dynamic shenanigans in Jason that would make that difficult |
|
Yeah, it was very straightforward. If I get sufficiently annoyed with staying up to date then I'll write a script :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents module conflicts with the user's version of Jason since both are loaded into the same beam instance (at least until #253) is addressed.
Functionally this was simply replacing
:jason=>:jason_vendoredandJasonwithJasonVendored. I only skipped the changelog (for no good reason) and thebenchdirectory data.Note: I plan to leave this PR open even though this branch is used by elixir-ls. I think that will facilitate seeing the changes as compared to the upstream Jason library. If we need to update to a new version of Jason the plan is to rebase this branch on top of the upstream changes (or just redo the changes).
This also formats the code which is another reason to just redo the changes.