Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added validation for gps and network provider permissions separa… #317

Merged

Conversation

caghp94
Copy link
Contributor

@caghp94 caghp94 commented May 29, 2024

Overview

This is a fix for #205 #315 and #272

The method getValidProvider was returning gps provider even when ACCESS_FINE_LOCATION was not granted, causing runtime exceptions.

@caghp94
Copy link
Contributor Author

caghp94 commented May 29, 2024

@michalchudziak please review this

Copy link
Owner

@michalchudziak michalchudziak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for solving this!

@israr002
Copy link

#272 is not fixed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants