[Bug]: Fix type error in NumericRange constructor when using decimals

Resolves pimcore#17700
michalananapps · Oct 18, 2024 · 4c3a006 · 4c3a006
1 parent f0620ff
commit 4c3a006
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/models/DataObject/ClassDefinition/Data/NumericRange.php b/models/DataObject/ClassDefinition/Data/NumericRange.php
@@ -240,10 +240,18 @@ public function getDataForResource(mixed $data, DataObject\Concrete $object = nu
     public function getDataFromResource(mixed $data, DataObject\Concrete $object = null, array $params = []): ?DataObject\Data\NumericRange
     {
         if (isset($data[$this->getName() . '__minimum'], $data[$this->getName() . '__maximum'])) {
-            $numericRange = new DataObject\Data\NumericRange(
-                $data[$this->getName() . '__minimum'],
-                $data[$this->getName() . '__maximum']
-            );
+            $minimum = $data[$this->getName() . '__minimum'];
+            $maximum = $data[$this->getName() . '__maximum'];
+
+            if (is_string($minimum)) {
+                $minimum = (float) $minimum;
+            }
+
+            if (is_string($maximum)) {
+                $maximum = (float) $maximum;
+            }
+
+            $numericRange = new DataObject\Data\NumericRange($minimum, $maximum);
 
             if (isset($params['owner'])) {
                 $numericRange->_setOwner($params['owner']);