-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DPF and CI builds; Fixes and LTO optimization #120
Conversation
Signed-off-by: falkTX <[email protected]>
Signed-off-by: falkTX <[email protected]>
JACK can be used on any OS now, and has RtAudio fallback Signed-off-by: falkTX <[email protected]>
Signed-off-by: falkTX <[email protected]>
Signed-off-by: falkTX <[email protected]>
Otherwise the build setup would depend on the plugin being built, we dont want that since this is a shared file Signed-off-by: falkTX <[email protected]>
AbstractUI imports DistrhoUI.hpp, which is different per plugin. Signed-off-by: falkTX <[email protected]>
Oh, I updated the CI builds to use Ubuntu 20.04, as with Ubuntu 18.04 we needed ugly hacks in order to cross-build ARM stuff. |
Thanks @falkTX! I'm going to do some additional work on the CI stuff to get if I can promote the resulting artifacts to downloadable releases. |
Cool, I will be on watch for that :) On a different topic, we should make the UI scalable to high-dpi at some point, DPF already provides such APIs ( |
Oh nice. I might try replacing the raster images with new higher detailed ones, and then scale down for low DPI instead of scaling up for high DPI. |
It's a bit sad to see the build fail in Ubuntu 18.04 with commit 886880 Maybe 20.04 could be the lowest supported ARM version, while still having a working x86/64 18.04? |
Having different setups for 18.04 and 20.04 complicates things. |
Never mind. I eventually noticed that I had set symlinks = false in my .gitconfig, to prevent an old security bug, and that created AbstractUI files containing back-references instead of proper symlinks |
Hi again, here comes a big one :)
Listing the changes, in no particular order:
DistrhoUI.hpp
is different per-plugin, so we cant share it across builds, a symlink works fine here)make WITH_LTO=true
in DPF) which should show small performance improvements