Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed xfail mark while testing mvnormal random #3

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

Sayam753
Copy link

This is a follow up PR of pymc-devs#4207. There, a few tests failed when size is either None or 1. So, I marked them as xfail.
These corner cases are resolved in pymc-devs#4214. This PR just removes the xfail mark.

@Sayam753 Sayam753 changed the title Removed xfail tests while testing mvnormal random Removed xfail mark while testing mvnormal random Dec 16, 2020
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (fix-4206@25f6108). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             fix-4206       #3   +/-   ##
===========================================
  Coverage            ?   87.88%           
===========================================
  Files               ?       88           
  Lines               ?    14458           
  Branches            ?        0           
===========================================
  Hits                ?    12707           
  Misses              ?     1751           
  Partials            ?        0           

@Sayam753
Copy link
Author

Hi @michaelosthege.
This PR is ready for review.

Copy link
Owner

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelosthege michaelosthege merged commit 1652e4b into michaelosthege:fix-4206 Dec 18, 2020
@Sayam753 Sayam753 deleted the remove-xfail branch August 16, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants