Fix RepositoryCommitsClient.GetSha1 API call after preview period end…

…ed (octokit#1654)

* Change GetSha1 for commit API call to use official media type accept header rather than preview header (which doesn't seem to work anymore)

* Missed 2 unit tests

Octokit.Tests/Clients/RepositoriesClientTests.cs

@@ -1062,7 +1062,7 @@ public void RequestsTheCorrectUrl()
                 client.GetSha1("owner", "name", "reference");
 
                 connection.Received()
-                    .Get<string>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference"), null, AcceptHeaders.CommitReferenceSha1Preview);
+                    .Get<string>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference"), null, "application/vnd.github.v3.sha");
             }
         }
     }

Octokit.Tests/Clients/RespositoryCommitsClientTests.cs

@@ -318,7 +318,7 @@ public async Task RequestsCorrectUrl()
                 await client.GetSha1("fake", "repo", "ref");
 
                 connection.Received().Get<string>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/commits/ref"),
-                    null, "application/vnd.github.chitauri-preview+sha");
+                    null, "application/vnd.github.v3.sha");
             }
 
             [Fact]
@@ -330,7 +330,7 @@ public async Task RequestsCorrectUrlWithRepositoryId()
                 await client.GetSha1(1, "ref");
 
                 connection.Received().Get<string>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/commits/ref"),
-                    null, "application/vnd.github.chitauri-preview+sha");
+                    null, "application/vnd.github.v3.sha");
             }
 
             [Fact]

Octokit/Clients/RepositoryCommitsClient.cs

@@ -190,7 +190,7 @@ public Task<string> GetSha1(string owner, string name, string reference)
             Ensure.ArgumentNotNullOrEmptyString(name, "name");
             Ensure.ArgumentNotNullOrEmptyString(reference, "reference");
 
-            return ApiConnection.Get<string>(ApiUrls.RepositoryCommit(owner, name, reference), null, AcceptHeaders.CommitReferenceSha1Preview);
+            return ApiConnection.Get<string>(ApiUrls.RepositoryCommit(owner, name, reference), null, AcceptHeaders.CommitReferenceSha1MediaType);
         }
 
         /// <summary>
@@ -202,7 +202,7 @@ public Task<string> GetSha1(long repositoryId, string reference)
         {
             Ensure.ArgumentNotNullOrEmptyString(reference, "reference");
 
-            return ApiConnection.Get<string>(ApiUrls.RepositoryCommit(repositoryId, reference), null, AcceptHeaders.CommitReferenceSha1Preview);
+            return ApiConnection.Get<string>(ApiUrls.RepositoryCommit(repositoryId, reference), null, AcceptHeaders.CommitReferenceSha1MediaType);
         }
     }
 }

Octokit/Helpers/AcceptHeaders.cs

@@ -10,6 +10,8 @@ public static class AcceptHeaders
 
         public const string RedirectsPreviewThenStableVersionJson = "application/vnd.github.quicksilver-preview+json; charset=utf-8, application/vnd.github.v3+json; charset=utf-8";
 
+        public const string CommitReferenceSha1MediaType = "application/vnd.github.v3.sha";
+
         public const string OrganizationPermissionsPreview = "application/vnd.github.ironman-preview+json";
 
         public const string LicensesApiPreview = "application/vnd.github.drax-preview+json";
@@ -19,9 +21,7 @@ public static class AcceptHeaders
         public const string StarCreationTimestamps = "application/vnd.github.v3.star+json";
 
         public const string IssueLockingUnlockingApiPreview = "application/vnd.github.the-key-preview+json";
-
-        public const string CommitReferenceSha1Preview = "application/vnd.github.chitauri-preview+sha";
-
+
         public const string SquashCommitPreview = "application/vnd.github.polaris-preview+json";
 
         public const string MigrationsApiPreview = "application/vnd.github.wyandotte-preview+json";