Skip to content

Commit

Permalink
Add missing ID property to Milestone (octokit#2007)
Browse files Browse the repository at this point in the history
* Add Id property to Milestone model

* Exclude Riders workspace directory
  • Loading branch information
hnrkndrssn authored and shiftkey committed Sep 21, 2019
1 parent ae10ba3 commit 63a4dea
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,7 @@ Backup/
tools/*
!tools/gitversion_wrapper.sh
!tools/LINQPad
coverage-results/*
coverage-results/*

# Rider
**/.idea/*
8 changes: 7 additions & 1 deletion Octokit/Models/Response/Milestone.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ public Milestone(int number)
Number = number;
}

public Milestone(string url, string htmlUrl, int number, string nodeId, ItemState state, string title, string description, User creator, int openIssues, int closedIssues, DateTimeOffset createdAt, DateTimeOffset? dueOn, DateTimeOffset? closedAt, DateTimeOffset? updatedAt)
public Milestone(string url, string htmlUrl, long id, int number, string nodeId, ItemState state, string title, string description, User creator, int openIssues, int closedIssues, DateTimeOffset createdAt, DateTimeOffset? dueOn, DateTimeOffset? closedAt, DateTimeOffset? updatedAt)
{
Url = url;
HtmlUrl = htmlUrl;
Id = id;
Number = number;
NodeId = nodeId;
State = state;
Expand All @@ -41,6 +42,11 @@ public Milestone(string url, string htmlUrl, int number, string nodeId, ItemStat
/// The Html page for this milestone.
/// </summary>
public string HtmlUrl { get; protected set; }

/// <summary>
/// The ID for this milestone.
/// </summary>
public long Id { get; protected set; }

/// <summary>
/// The milestone number.
Expand Down

0 comments on commit 63a4dea

Please sign in to comment.