Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress the 'Fatal: not a git repository' errors #8

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Suppress the 'Fatal: not a git repository' errors #8

merged 1 commit into from
Aug 26, 2015

Conversation

justinas
Copy link
Contributor

This one command was not silenced and caused the mentioned error when the working directory is not a git repo.

@michaeldfallen
Copy link
Owner

Thank you for this. Any chance you can write a test for it? Or give me a run down of the conditions you saw it cause an issue? Then I can write the test myself.

Thanks 🙇

@justinas
Copy link
Contributor Author

Happens on OS X Yosemite with zsh. Starting a new shell in a directory that's not a Git repo (or cd-ing into one later, for that matter) prints out the error message for every new line of the shell.

@michaeldfallen
Copy link
Owner

Odd, the is_repo check is meant to prevent that from being called.

@michaeldfallen
Copy link
Owner

I'll merge but that hasn't happened from me using this for over a year personally. Hmmm, smells of an underlying issue in is_repo or dot_git function.

michaeldfallen added a commit that referenced this pull request Aug 26, 2015
Suppress the 'Fatal: not a git repository' errors
@michaeldfallen michaeldfallen merged commit 6aeb81d into michaeldfallen:master Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants