-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable selection - update all methods #15
base: variable_selection
Are you sure you want to change the base?
Variable selection - update all methods #15
Conversation
AniekMarkus
commented
Oct 31, 2023
- Methods implemented with the following design principle:
- All feature engineering methods combined in one R script VariableSelection.R
…variable_selection_updateAllMethods
…variable_selection_updateAllMethods
This pull request includes branches:
|
This check is failing:
|
I just looked at the failing test. That was because the |
@AniekMarkus currently this is failing because of warnings in the R check. Generally we want to make sure it passes R check (no errors and warnings) locally before creating a PR. You can run it locally using devtools |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## variable_selection #15 +/- ##
======================================================
- Coverage 86.85% 85.80% -1.05%
======================================================
Files 51 50 -1
Lines 9867 10006 +139
======================================================
+ Hits 8570 8586 +16
- Misses 1297 1420 +123 ☔ View full report in Codecov by Sentry. |