Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resultsExplore and test #29

Merged
merged 8 commits into from
Oct 1, 2024
Merged

resultsExplore and test #29

merged 8 commits into from
Oct 1, 2024

Conversation

cebarboza
Copy link
Collaborator

Here is the first attempt for resultsExplore. I added a test in test-MainFunctions. As you mentioned, it is a good idea to access any result without running everything again. I left the option to get several results in testExplore, so it is easier to not call resultsExplore in every test.

@AniekMarkus
Copy link
Contributor

Great that you have added resultsExplore! I do think it would be useful to have as output of that function this list format (can be extended with more items, but I think these are most important):

results <- list("model" = rule_string,
                  "candidateModels" = candidate_models,
                  "countCombinations" = total_count_combinations,
                  "countFeatureOperatorPairs" = total_count_feature_operator_pairs ,
                  "countRulesWithoutConstraints" = total_count_cutoff_sets,
                  "countRulesWithConstraints" = total_count_candidates_(incl_constraints)
)

For the trainExplore function I think we should choose the standard output to be what users expect to be returned; i.e. the model so have resultType = c("model") as default? Then you can still use the other resultTypes for testing purposes. That way it also still nicely works when calling predictExplore afterwards.

@cebarboza What do you think?

@cebarboza cebarboza merged commit 2cd294b into unary_function_change Oct 1, 2024
@cebarboza cebarboza deleted the resultsExplore branch October 1, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants