ignore empty root dir name when compressing file #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks! I'll await confirmation from @nicola-spb and if it fixes the issue we can merge this in |
|
I find that FilesFromDisk will never return error, because it never checks error from filepath.Walk, (the error in walk func will stop walk but will not be returned). |
|
@WeidiDeng Wow, you are right. I missed that too 😄 |
|
@mholt Hi |
mholt
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
This is great, thank you very much for the patch @WeidiDeng, and thanks to @nicola-spb for confirming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 350