[ISSUE-71] Hash keys and serialize/compress payload responses#72
[ISSUE-71] Hash keys and serialize/compress payload responses#72jlurena wants to merge 3 commits intomhgbrown:masterfrom jlurena:ISSUE-71
Conversation
mhgbrown
left a comment
mhgbrown
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left some questions for you.
lib/cached_resource/caching.rb
Outdated
There was a problem hiding this comment.
What do you think about making packing/unpacking another configurable option?
There was a problem hiding this comment.
Yeah thats what I was asking whether we should maintain it configurable or not. I can't think why anyone would not want this though.
If we make it configurable, we would have to require this dynamically based on the configuration option, which IMO is not an issue - just couldn't decide on whether this should be the norm or not.
I'll let you decide, configurable or norm? @mhgbrown
There was a problem hiding this comment.
Let's go configurable! Thanks for laying it out for me.
There was a problem hiding this comment.
yeah the configuration part been a bit busy sorry
There was a problem hiding this comment.
No worries, thanks for the udpate. I see you made another commit. I'll check it out...
There was a problem hiding this comment.
Yep! Did as you asked.
Hey do you have discord or something? I'm hoping you can help me setup a pre version of cached_resource that makes use of this version of ActiveResource:
There was a problem hiding this comment.
Hi @mhgbrown hope you had a festive new year and holidays! I think this PR should be closed, hashing keys may interfere with clearing cache and MessagePack may not be used by everyone
There was a problem hiding this comment.
Hey! Thank you and same to you. Ok, I'll close it. Thanks again for your work and research.
2 participants
No description provided.