Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Split ESLint config in to Default, React, NextJS etc. #14

Closed
mheob opened this issue Aug 23, 2022 · 0 comments · Fixed by #19
Closed

[FEAT]: Split ESLint config in to Default, React, NextJS etc. #14

mheob opened this issue Aug 23, 2022 · 0 comments · Fixed by #19
Assignees
Labels
enhancement New feature or request eslint Belongs to ESLint config

Comments

@mheob
Copy link
Owner

mheob commented Aug 23, 2022

Currently, the ESLint configuration consists of all possible variants, such as React and NextJS. It doesn't matter if the specialized rules and packages are needed or not. Therefore, it makes sense to split these rules into smaller packages.

@mheob mheob added enhancement New feature or request eslint Belongs to ESLint config labels Aug 23, 2022
mheob added a commit that referenced this issue Aug 26, 2022
For now we use "base", "next" and "react" as separeted configurations.
Base is the default.

BREAKING CHANGE: The default config is now only "base", instead of all of them.
Resolves #14
@kodiakhq kodiakhq bot closed this as completed in #19 Aug 26, 2022
kodiakhq bot pushed a commit that referenced this issue Aug 26, 2022
Resolves #14

## 📑 Description

Split the ESLint config into specialized parts. For now, we use "base", "next" and "react" as separated configurations. Base is the default.


## ⚠️ BREAKING CHANGE

The default config is now only "base", instead of all of them.

## ✏️ Side Note

To ignore the `.changeset` folder from prettier, I added a custom ignore file.
@mheob mheob self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request eslint Belongs to ESLint config
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant