Use ConnectionPool blocks to ensure exclusive connection. Closes #66. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therabidbanana
force-pushed
the
master
branch
from
f311a11 to
6b3f23e
Compare
|
Nice work! Really appreciate the effort; what about those last couple of style violations thouh? :) |
mhenrixon
added a commit
that referenced
this pull request
Dec 15, 2014
Use ConnectionPool blocks to ensure exclusive connection. Closes #66.
|
The last few appeared to be in files that weren't part of the commit, and wasn't sure if I should touch those as part of this request - seems like a separate PR might be in order if someone wants to tackle those. :) |
|
Its cool I took care of it, was probably due to the too optimistic gem version on rubocop. It just gets more anal every day that copper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.