Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow worker to configure client and server strategies separately #402

Closed
mhenrixon opened this issue Jun 3, 2019 · 0 comments · Fixed by #462
Closed

Allow worker to configure client and server strategies separately #402

mhenrixon opened this issue Jun 3, 2019 · 0 comments · Fixed by #462

Comments

@mhenrixon
Copy link
Owner

mhenrixon commented Jun 3, 2019

Is your feature request related to a problem? Please describe.
One current bug is in regards to until_and_while_executing. The client and server lock can't use all the same strategies and people run into stackoverflow exceptions.

Describe the solution you'd like
Introduce a new API with a fallback to the old one and use the worker options validation to give the user feedback about incompatible strategies.

sidekiq_options lock: :until_and_while_executing, on_conflict: { client: :log, server: :raise } 

OR

unique_lock :until_and_while_executing, on_conflict: { client: :log, server: :raise } 
@mhenrixon mhenrixon added this to the V7.0 milestone Jun 3, 2019
@mhenrixon mhenrixon self-assigned this Jun 3, 2019
mhenrixon added a commit that referenced this issue Nov 28, 2019
mhenrixon added a commit that referenced this issue Nov 28, 2019
* Separate client and server on_conflict

Close #402

* Mandatory reek/rubocop commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant