Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for UpdateShardCound & DescribeLimits #48

Closed

Conversation

indieisaconcept
Copy link

This change adds support for UpdateShardCount & DescribeLimits.

Notable Additions

util.createShards
The creation of shards is now a separate utility function as there was an overlap between creating a streams initial shards and adding further via UpdateShardCound.

./test/helpers
When creating an instance of kinesalite for testing, helpers.shardLimit was not passed as an option. This PR also address this.

.editorconfig
Added for future contributors convenience.

@indieisaconcept
Copy link
Author

Closing due to discovery of issue with UpdateShardCount

@Druotic
Copy link

Druotic commented Mar 3, 2019

Hey @indieisaconcept, could you provide some more context around the issue that you found with UpdateShardCount? I may take a stab at picking this back up, as it would enable Terraform provisioning of Kinesis streams (via localstack, which uses this project). (#61) Any context from your previous attempt to help save me some time would be appreciated.

@indieisaconcept
Copy link
Author

@Druotic in all honesty I cannot recall. It was possibly because I discovered the time-based restrictions imposed with UpdateShardCount & was intending on adding that functionality for completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants