Handle properly SINGINT and SIGTERM signals #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mhart,
This is a pull request to manage properly the
SINGINT
andSIGTERM
signals when Kinesalite is bundle in a Docker container.Context
The current behavior is due to a change introduced by c61b0e9 in Node.
With this commit, when a user sends SIGINT by pressing CTRL-C in a terminal where node is the foreground process, the node process doesn't exit explicitly and instead forward the signal.
Please read this issue for more information: nodejs/node-v0.x-archive#9131
Impact
When Kinesalite run in a Docker container (as
PID 1
) and we send aSIGINT
orSIGTERM
signal withCTRL+C
the container does not exit properly: