Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure data is not a number in Buffer constructor #9

Merged
merged 1 commit into from
May 17, 2018
Merged

Ensure data is not a number in Buffer constructor #9

merged 1 commit into from
May 17, 2018
+1 −1

Conversation

mhart
Copy link
Owner

@mhart mhart commented May 17, 2018

Fixes #7

This was referenced May 17, 2018
Closed
Closed
KittyGiraudel
KittyGiraudel approved these changes May 17, 2018
View reviewed changes
Copy link

@KittyGiraudel KittyGiraudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that will do the trick. Thank you for fixing it that quickly. Do you think we could have a new version on npm? :)

@mhart
Copy link
Owner Author

mhart commented May 17, 2018

Tested and works fine. Merging :shipit:

@mhart mhart merged commit 2f4a9d4 into master May 17, 2018
This was referenced Mar 7, 2021
Open
Open
Merged
Open
Merged
Open
Open
Closed
Closed
Merged
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Merged
This was referenced Mar 15, 2021
Open
Closed
Merged
Merged
Merged
Closed
Open
Merged
Closed
Merged
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
@CMaheshBL CMaheshBL mentioned this pull request May 6, 2022
Open
@RobertMickleCx RobertMickleCx mentioned this pull request Mar 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KittyGiraudel KittyGiraudel KittyGiraudel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhart @KittyGiraudel