-
Notifications
You must be signed in to change notification settings - Fork 844
Native ARM64 CI builds and tests #2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6193867
to
f25b8e4
Compare
7add533
to
22b2594
Compare
Alright, I'm getting actual failed tests on ARM64 now. Not too surprising since I doubt many contributors have an AMR64 Windows machine. I think this is the failing test: https://github.com/mhammond/pywin32/actions/runs/14699426077/job/41246179979?pr=2581#step:11:500
The only matching error message I could find is this: pywin32/com/win32com/src/univgw.cpp Lines 264 to 268 in ddc14b2
|
except NotImplementedError: | ||
if platform.machine() == "ARM64": | ||
raise SkipTest( | ||
"`win32com.universal.RegisterInterfaces` doesn't support ARM64 yet" | ||
) | ||
raise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I carved this very specific exception so that if support is added (or attempted) and the error changes or disappears, this will have to be updated accordingly (hopefully by removing the try-except entirely)
Announcement: https://github.com/orgs/community/discussions/155713
Predecessor / based on:
--config-setting=--build-option
commands #2583Changes unique to this PR:
Build and test
jobmake_all.bat
to directly point to cross-compilation info