Skip to content

Set specific non-UTF8 encodings for 2 known files in .gitattributes #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Set specific non-UTF8 encodings for 2 known files in .gitattributes #2496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f1e86c
Set specific encodings for 2 known files, then run `git add --renorma…
Avasam Mar 16, 2025
92ef584
Merge branch 'main' of https://github.com/mhammond/pywin32 into renor…
Avasam Mar 26, 2025
9fed1e8
Merge branch 'main' of https://github.com/mhammond/pywin32 into renor…
Avasam Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
AutoDuck/*.fmt text eol=crlf
*.dsp text eol=crlf
*.dsw text eol=crlf

# Files that can't be in UTF-8 encoding
com/TestSources/PyCOMTest/PyCOMTest.idl working-tree-encoding=latin1
Pythonwin/pywin/test/_dbgscript.py working-tree-encoding=latin1
2 changes: 1 addition & 1 deletion Pythonwin/pywin/test/_dbgscript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#
# Script for testing pywin.debugger & interactive exec from test_pywin

# Umlauts for encoding test: ������
# Umlauts for encoding test: áéúäöü

aa = 11
aa = 22
Expand Down
6 changes: 4 additions & 2 deletions com/TestSources/PyCOMTest/PyCOMTest.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// -*- coding: latin1 -*-

// PyCOMTest.idl : IDL source for PyCOMTest.dll
//
// This is a test harness for Python
Expand Down Expand Up @@ -26,7 +28,7 @@ typedef enum // Missing EnumTestAttributes2
uuid(6bcdcb60-5605-11d0-ae5f-cadd4c000000),
version(1.1),
// an extended character in the help string should stress things...
helpstring("Python COM Test Harness 1.0 Type Library, � pywin32 contributors")
helpstring("Python COM Test Harness 1.0 Type Library, © pywin32 contributors")
Copy link
Collaborator Author

@Avasam Avasam Mar 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of only 2 places where this symbol is used. The other being

pywin32/win32/Lib/win32timezone.py

Line 10 in c5a30d2

Copyright © 2003-2012.

Everywhere else is either (c) (136 times) or (C) (17 times)

It could just be changed to (c)

]
library PyCOMTestLib
{
Expand Down Expand Up @@ -70,7 +72,7 @@ library PyCOMTestLib
const long LongTest2 = 0x7FFFFFFFL;
const unsigned char UCharTest = 255;
const char CharTest = -1;
const LPWSTR StringTest = L"Hello Wo�ld";
const LPWSTR StringTest = L"Hello Wo®ld";
};

enum TestAttributes3{ // Note missing the enum name.
Expand Down
2 changes: 0 additions & 2 deletions com/win32com/demos/iebutton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# -*- coding: latin-1 -*-

# PyWin32 Internet Explorer Button
#
# written by Leonard Ritter ([email protected])
Expand Down
2 changes: 0 additions & 2 deletions com/win32com/demos/ietoolbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# -*- coding: latin-1 -*-

# PyWin32 Internet Explorer Toolbar
#
# written by Leonard Ritter ([email protected])
Expand Down