Fix crash in PyIShellIconOverlayIdentifier::IsMemberOf with Python 3.12 #2466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's exactly the same pattern that caused issue #2415 which was fixed with PR #2417. It looks like Python < 3.12 was more forgiving. It might have to do with the code changes in 3.12 to prepare for getting rid of the GIL. However, if you found other places with this pattern, it would be great if you could fix them in another PR. |
|
No changes after fixing conflicts (a single newline difference). This was included in https://github.com/mhammond/pywin32/pull/2467/files#diff-a19942c574a1cd9e2d9cf76408893d870a9c871d44d4a65b2bdf5ffdd0a43ec5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
we are currently migrating our application from Python 3.11 to 3.12 and encountered a crash (access violation) determining overlay images of files via the
IShellIconOverlayIdentifier.We found out that the crash can be fixed by simply moving the
PyObject_FreeWChar()method after the PY_INTERFACE_POSTCALL, so GIL is aquired.So from my understand, it is not allowed to do any memory deallocation on PyObjects without having the GIL. I found this "bad" pattern in some more places. I will create a second pull request with those changes, as I only tested the change of this pull request.