-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pywin32_postinstall
and pywin32_testall
into Console Scripts
#2408
Open
Avasam
wants to merge
6
commits into
mhammond:main
Choose a base branch
from
Avasam:console_scripts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−13
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bc7ad11
Make pywin32_postinstall and pywin32_testall into console_scripts
Avasam 6b0b163
Merge branch 'main' into console_scripts
Avasam 31eb27c
Merge branch 'main' of https://github.com/mhammond/pywin32 into conso…
Avasam d3f9f60
Run tests from source
Avasam ecd8a5a
Merge branch 'main' of https://github.com/mhammond/pywin32 into conso…
Avasam 9e55aa4
fix project root location
Avasam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2108,7 +2108,18 @@ def convert_optional_data_files(files): | |
license="PSF", | ||
classifiers=classifiers, | ||
cmdclass=cmdclass, | ||
scripts=["pywin32_postinstall.py", "pywin32_testall.py"], | ||
# This adds the scripts under Python3XX/Scripts, but doesn't actually do much | ||
scripts=[ | ||
"win32/scripts/pywin32_postinstall.py", | ||
"win32/scripts/pywin32_testall.py", | ||
], | ||
Comment on lines
+2080
to
+2084
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm keeping this for now as to not break some poor sysadmin's workflow of looking in Python's Scripts folder 😉 (then again, they were probably using .exe installers, but it's barely 4 lines to keep the support) |
||
# This shortcuts `python -m win32.scripts.some_script` to just `some_script` | ||
entry_points={ | ||
"console_scripts": [ | ||
"pywin32_postinstall = win32.scripts.pywin32_postinstall:main", | ||
"pywin32_testall = win32.scripts.pywin32_testall:main", | ||
] | ||
}, | ||
ext_modules=ext_modules, | ||
package_dir={ | ||
"win32com": "com/win32com", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing test https://github.com/mhammond/pywin32/actions/runs/12308761196/job/34354669586?pr=2408#step:7:316 and comment
tell me that it maybe didn't even make sense that the test was shipped in the first place (or could be modified to skip some tests when not run from source)