Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a circular import between win32comext.axscript.client.framework and win32comext.axscript.client.error #2381

Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Oct 5, 2024

Fixes a regression in 307 found whilst updating typeshed's pywin32 stubs

Whilst this area of code isn't automatically tested, there are ways we can automatically safeguard against this kind of issue by detecting imports that are only used for annotations: https://docs.astral.sh/ruff/rules/#flake8-type-checking-tch

@mhammond
Copy link
Owner

mhammond commented Oct 6, 2024

there are ways we can automatically safeguard against this kind of issue by detecting imports that are only used for annotations

Might as well enable whatever rules make sense for annotations 👍

@Avasam Avasam merged commit 303acfd into mhammond:main Oct 6, 2024
28 checks passed
@Avasam Avasam deleted the Circular-imports-in-win32comext.axscript.client branch October 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants