Fix Python failure handling in Pythonwin/pywin/framework/scriptutils.py
#2319
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Jul 25, 2024
Avasam
commented
Jul 25, 2024
| else: | ||
| traceback.print_exc() | ||
| win32ui.SetStatusText("Failed to " + what + " - " + str(details)) | ||
| win32ui.SetStatusText(f"Failed to {what} - {type(details)} - {details}") |
There was a problem hiding this comment.
Deduplicated win32ui.SetStatusText.
I have also considered the following:
Suggested change
| win32ui.SetStatusText(f"Failed to {what} - {type(details)} - {details}") | |
| win32ui.SetStatusText(f"Failed to {what} - {details!r}") |
Avasam
commented
Jul 25, 2024
| else: | ||
| traceback.print_exc() | ||
| win32ui.SetStatusText("Failed to " + what + " - " + str(details)) | ||
| win32ui.SetStatusText(f"Failed to {what} - {type(details)} - {details}") | ||
| tb = None # Clean up a cycle. |
There was a problem hiding this comment.
What does this tb = None do exactly?
Avasam
force-pushed
the
scriptutils-handle-failure
branch
from
c851363 to
d285d40
Compare
…tutils-handle-failure
…tutils-handle-failure
Avasam
commented
Mar 26, 2025
| try: | ||
| msg, (fileName, line, col, text) = details |
There was a problem hiding this comment.
This code would produce:
TypeError: cannot unpack non-iterable SyntaxError object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and improve error message
The previous code would produce a
TypeError: cannot unpack non-iterable SyntaxError objectonSyntaxError