allow ignoring unknown files + tests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AubreyHewes
force-pushed
the
dev-allow_ignoring_unknown_files
branch
2 times, most recently
from
14c6072
to
7dcf5e7
Compare
AubreyHewes
force-pushed
the
dev-allow_ignoring_unknown_files
branch
from
7dcf5e7
to
8887c17
Compare
|
This seems like it could be done if a file is truly untracked (I don't think we could do it for tracked changed files because of all |
mgol
force-pushed
the
master
branch
2 times, most recently
from
86d0015
to
8d03e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow ignoring unknown files...
a project may contain files that are not ready to be committed (unknown; not yet git added).. this lets you npm-bump even if your project contains unknown files...
Current logic was to break on any output from
git status -s.. This change allows execution when the files start with??(unknown files; not yet added)..I had to change some stuff to be able to create tests... As there are not any tests I did not want to refactor the module for easier/normal test support. I have only done the bare minimum to create tests that support the change...
A possible todo is to add a prompt confirming you want to ignore these files.. or just mention the unknown files...