[SLO] Overview embeddable feedback#3
Merged
mgiota merged 11 commits intomgiota:slo-overview-embeddable-schema-registrationfrom Feb 24, 2026
Merged
[SLO] Overview embeddable feedback#3mgiota merged 11 commits intomgiota:slo-overview-embeddable-schema-registrationfrom
mgiota merged 11 commits intomgiota:slo-overview-embeddable-schema-registrationfrom
Conversation
mgiota
merged commit 43be022
into
mgiota:slo-overview-embeddable-schema-registration
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke x-pack/solutions/observability/plugins/slo/server/lib/embeddables/register_overview_embeddable_transforms.test.ts into smaller tests that test schema and transform from their source files to avoid having extra overhead of extracting them from
getTransformscall. I always find it best to test logic as close to source code as possible.