display_width: ignore ANSI hyperlinks in width calculation
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was actually hit by this bug and found this PR. @mgeisler any chance you can take a look 🐱 |
tertsdiepraam
force-pushed
the
ansi-hyperlink
branch
from
4e44371
to
5d28004
Compare
|
I added support for a BEL character as separator between the link and the text. This is used by some programs such as GNU |
|
Thanks for the ping! I'm sorry I had forgotten about this... let's merge it right away so I can make a new release. |
|
Thanks! |
Merged
|
I finally got around to merge the release PR: #533 and this means 0.16.1 is available! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #525
I've attempted to keep the implementation similar to the current implementation and added a simple test for it. This keeps it in a bit of an awkward state (e.g. comparing with
CSI.1in one branch and']'in the other). Happy to take suggestions for the direction to take this PR!