Fix unfill and refill crashes
#467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash is actually in `unfill`. After processing the first line, we would erroneously use the `options.initial_indent` to index into the second line. This lead to a panic when the second line is shorter than the first line.
Test that we don't crash on a `\r` following a string of `\n`. The problem was that we removed both kinds of characters in one code path, but not in the other. We now use the same `text` in both places and this fixes the issue. The fix changed the handling of newlines slightly: we now normalize the newlines to a single `\n` or `\r\n` depending on what we detect in the input. The documentation was updated to explicitly say that passing in multiple paragraphs result in unspecified behavior.
mgeisler
force-pushed
the
fix-refill-crashes
branch
from
16bd549
to
0a75ed9
Compare
Merged
|
@mgeisler , sorry for the late response. It's hard to recall now, but I guess it was to allow unfill to operate on multiple paragraphs would be unfilled into That's the only explanation I can think of right now 🙈 |
|
Hi @edio, Thanks, multiple paragraphs is something we might want to support one day... I think that would name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in
unfill, both to do with the way we were slicing strings in cases where the input ended with a combination of\rand\n.Fixes #466.