Respect non breaking spaces #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-breaking spaces are (obviously) treated as whitespace characters by the String::split_whitespace method, which meant that we would happily break words on such spaces. We now use String::split instead with our own predicate. Somewhat surprisingly, using String::split is about 15-20% faster than using String::split_whitespace, so we even get a performance boost out of this new code. Fixes #39.
There is such a thing as a non-breaking hyphen. We did not break words on those and this new test helps to verify this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-breaking spaces are (obviously) treated as whitespace characters
by the String::split_whitespace method, which meant that we would
happily break words on such spaces. We now use String::split instead
with our own predicate.
Fixes #39.